Add pygame.system.get_theme() (w/ sdl3)#3325
Add pygame.system.get_theme() (w/ sdl3)#3325damusss wants to merge 2 commits intopygame-community:mainfrom
pygame.system.get_theme() (w/ sdl3)#3325Conversation
damusss
added
New API
|
I don't think we're ready to have PRs like this yet. We don't have any branches, any releases targeting SDL3 right now. We need to get stuff compiling on SDL3 first. Let's say this merges, now everyone who reads the system docs sees a function that they have no way of using. And the description doesn't even say that this function is impossible to use, it only says it requires SDL3, which is not a statement most of our users will understand the implications of. |
|
@Starbuck5 don't worry I'm aware that it will take a while for it to get in, i just followed roughly the indications ankith gave me not to have too many stagnant branches in my fork. btw what % are we in sdl3 porting? |
That's a difficult question. Maybe 50% ? |
|
This will be revived (and more prs with sdl3 api will be made) when there is a clear direction/decision about where to put sdl3 prs, and about what version holds sdl3 compatibility |
2 participants
I implemented fully what the title says, "fixing" half of #2760 (comment)
The codebase doesn't compile with sdl3 yet, so I'm not sure what kind of versionadded to put.
Depending on which PR gets in before compared to #3296 the other will have to be updated I guess.